dyninst.git
7 years agoWarning cleanup. Applying RH's Dyninst patches to 8.1, this one originally by Willia...
Matthew LeGendre [Wed, 27 Feb 2013 17:28:23 +0000 (09:28 -0800)]
Warning cleanup.  Applying RH's Dyninst patches to 8.1, this one originally by William Cohen

7 years agoFedora 17's /lib64/libc.so is a script for the linker, which caused our relocation...
Andrew Bernat [Wed, 27 Feb 2013 16:00:47 +0000 (10:00 -0600)]
Fedora 17's /lib64/libc.so is a script for the linker, which caused our relocation test to fail. We now continue looking for other libc.so files until we find a shared library.

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Wed, 27 Feb 2013 03:41:00 +0000 (21:41 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoRemove accidentally committed debug output.
Andrew Bernat [Wed, 27 Feb 2013 03:40:41 +0000 (21:40 -0600)]
Remove accidentally committed debug output.

7 years agoRobust registerSignalHandlerCallback implementation using BPatch_Set pointer
Zuyu Zhang [Wed, 27 Feb 2013 02:09:46 +0000 (20:09 -0600)]
Robust registerSignalHandlerCallback implementation using BPatch_Set pointer

7 years agoRe-add BPatch_Set implementation of registerSignalHandlerCallback for backwards compa...
Andrew Bernat [Wed, 27 Feb 2013 00:18:16 +0000 (18:18 -0600)]
Re-add BPatch_Set implementation of registerSignalHandlerCallback for backwards compatibility

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Wed, 27 Feb 2013 00:15:30 +0000 (18:15 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoSwitch the test suite to use C++11x
Andrew Bernat [Wed, 27 Feb 2013 00:15:15 +0000 (18:15 -0600)]
Switch the test suite to use C++11x

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Zuyu Zhang [Tue, 26 Feb 2013 22:47:57 +0000 (16:47 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years ago1) Reverted my fix for ret ROSE representation. Now remove the implicit
Zuyu Zhang [Tue, 26 Feb 2013 22:22:59 +0000 (16:22 -0600)]
1) Reverted my fix for ret ROSE representation. Now remove the implicit
operand, ESP, from InstructionAPI operands for ret insn before
we handle with its corresponding ROSE representation.
2) Remove incorrect assert when restore ESP value.
3) Replace BPatch_Set with STL Set for registering Signal Handler CB.

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Tue, 26 Feb 2013 21:58:54 +0000 (15:58 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoWork around a race between multiple invocations of pc_thread
Andrew Bernat [Tue, 26 Feb 2013 21:58:48 +0000 (15:58 -0600)]
Work around a race between multiple invocations of pc_thread

7 years agofix power_decode test for bg/q insn differences
William R. Williams [Tue, 26 Feb 2013 21:27:58 +0000 (13:27 -0800)]
fix power_decode test for bg/q insn differences

7 years agoFix install problem as suggested by Joseph Schuchart
Andrew Bernat [Tue, 26 Feb 2013 20:04:30 +0000 (14:04 -0600)]
Fix install problem as suggested by Joseph Schuchart

7 years agoUpdate the conditional memory operation count; it's been wrong for years.
Andrew Bernat [Mon, 25 Feb 2013 23:50:33 +0000 (17:50 -0600)]
Update the conditional memory operation count; it's been wrong for years.

7 years agoFixes for BGQ PC timeouts when waiting for lost messages
Matthew LeGendre [Mon, 25 Feb 2013 22:57:11 +0000 (14:57 -0800)]
Fixes for BGQ PC timeouts when waiting for lost messages

7 years agoAdd /lib64 to search path for test_relocations
Andrew Bernat [Mon, 25 Feb 2013 22:00:40 +0000 (16:00 -0600)]
Add /lib64 to search path for test_relocations

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Mon, 25 Feb 2013 20:00:39 +0000 (14:00 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoMatt's BG/Q test change caused failures on RHEL 5 in attach mode, pc_stat and pc_thre...
Andrew Bernat [Mon, 25 Feb 2013 19:58:26 +0000 (13:58 -0600)]
Matt's BG/Q test change caused failures on RHEL 5 in attach mode, pc_stat and pc_thread. Commit reverted until we can work this out.

7 years agoFixed NULL AST pointer bug in dataflowAPI when expending Assignment
Zuyu Zhang [Sun, 24 Feb 2013 16:24:57 +0000 (10:24 -0600)]
Fixed NULL AST pointer bug in dataflowAPI when expending Assignment

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Zuyu Zhang [Sat, 23 Feb 2013 21:05:17 +0000 (15:05 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoFixed assertion failed when fail to find given function in Windows kernel lib
Zuyu Zhang [Sat, 23 Feb 2013 20:59:07 +0000 (14:59 -0600)]
Fixed assertion failed when fail to find given function in Windows kernel lib

7 years agoFixed iterator for block list bug in dataflowAPI and ROSE representation bug for...
Zuyu Zhang [Sat, 23 Feb 2013 20:51:16 +0000 (14:51 -0600)]
Fixed iterator for block list bug in dataflowAPI and ROSE representation bug for ret insn

7 years agoFixed invalid iterator bug for ret blocks in ParseAPI when tampering stack
Zuyu Zhang [Sat, 23 Feb 2013 20:07:26 +0000 (14:07 -0600)]
Fixed invalid iterator bug for ret blocks in ParseAPI when tampering stack

7 years agoFix a bug calculating branch offsets for if snippets
Paradyn Project [Fri, 22 Feb 2013 22:14:35 +0000 (14:14 -0800)]
Fix a bug calculating branch offsets for if snippets

7 years agoMerge branch 'master' into bgq_attach_timeout
Matthew LeGendre [Fri, 22 Feb 2013 19:02:52 +0000 (11:02 -0800)]
Merge branch 'master' into bgq_attach_timeout

Conflicts:
proccontrol/src/bluegeneq.h

7 years agoClean up old RT lib loading code; removes a symbol collision error between Dyninst... pre-8.1
Andrew Bernat [Fri, 22 Feb 2013 18:16:25 +0000 (12:16 -0600)]
Clean up old RT lib loading code; removes a symbol collision error between Dyninst and ProcControl.

7 years ago1) Implement multi-register loads for PPC64 rather than asserting
Andrew Bernat [Fri, 22 Feb 2013 17:52:49 +0000 (11:52 -0600)]
1) Implement multi-register loads for PPC64 rather than asserting
2) Remove incorrect assert in parsing
3) Check for a valid PLATFORM variable and ignore it if incorrect, rather than failing to build

7 years agoFix a system crash when running the test suite as root
Andrew Bernat [Thu, 21 Feb 2013 19:14:29 +0000 (13:14 -0600)]
Fix a system crash when running the test suite as root

7 years agoFixes for reading from persistant file system on BGQ
Matthew LeGendre [Wed, 20 Feb 2013 17:53:25 +0000 (09:53 -0800)]
Fixes for reading from persistant file system on BGQ

7 years agoMerge branch 'master' into bgq_ramdisk_io
Matthew LeGendre [Wed, 20 Feb 2013 17:53:02 +0000 (09:53 -0800)]
Merge branch 'master' into bgq_ramdisk_io

Conflicts:
proccontrol/make.module.tmpl
proccontrol/src/linux.h

7 years agoWorkaround BGQ system issue in PC where breakpoint event reported as single step.
Matthew LeGendre [Tue, 19 Feb 2013 22:28:13 +0000 (14:28 -0800)]
Workaround BGQ system issue in PC where breakpoint event reported as single step.

7 years agoBGQ was building the StackwalkerAPI as its default component. Changed to DyninstAPI.
Matthew LeGendre [Tue, 19 Feb 2013 22:27:21 +0000 (14:27 -0800)]
BGQ was building the StackwalkerAPI as its default component.  Changed to DyninstAPI.

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Matthew LeGendre [Tue, 19 Feb 2013 18:33:36 +0000 (10:33 -0800)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

Conflicts:
configure
configure.in
proccontrol/src/bluegeneq.h
proccontrol/src/int_thread_db.C

7 years agoFix BGQ PC test issue with mutators dying from system sent SIGTERMs
Matthew LeGendre [Tue, 19 Feb 2013 18:04:10 +0000 (10:04 -0800)]
Fix BGQ PC test issue with mutators dying from system sent SIGTERMs

7 years agoFix issue where BGQ PC would repeat reads of PC while single stepping
Matthew LeGendre [Tue, 19 Feb 2013 18:02:41 +0000 (10:02 -0800)]
Fix issue where BGQ PC would repeat reads of PC while single stepping

7 years agoMisc bug fixes for recent SSE commit
Mike Lam [Wed, 13 Feb 2013 19:31:01 +0000 (14:31 -0500)]
Misc bug fixes for recent SSE commit
We were double-adding the ModRM byte for some instructions; fixed

7 years agoBug fix for infinite loop in analysis stepper.
Bill Williams [Mon, 18 Feb 2013 16:17:43 +0000 (10:17 -0600)]
Bug fix for infinite loop in analysis stepper.
Changed const Instruction::Ptr& to Instruction::Ptr for clearer semantics.
Added --disable-m32 option to configure.

7 years agoFix BGQ pc_thread problem where test pipe send collides with recv
Matthew LeGendre [Sat, 16 Feb 2013 00:17:55 +0000 (16:17 -0800)]
Fix BGQ pc_thread problem where test pipe send collides with recv

7 years agoHave pc_group test on BGQ use mmap to find free memory
Matthew LeGendre [Sat, 16 Feb 2013 00:17:28 +0000 (16:17 -0800)]
Have pc_group test on BGQ use mmap to find free memory

7 years agoIRPCs allocated with getExecMemory weren't saving/restoring the original memory at...
Matthew LeGendre [Sat, 16 Feb 2013 00:16:39 +0000 (16:16 -0800)]
IRPCs allocated with getExecMemory weren't saving/restoring the original memory at that location.

7 years agoReorder PC test startup operations to work better on BGQ
Matthew LeGendre [Fri, 15 Feb 2013 01:13:16 +0000 (17:13 -0800)]
Reorder PC test startup operations to work better on BGQ

7 years agoFix more valgrind found test-before-set errors
Matthew LeGendre [Fri, 15 Feb 2013 01:12:44 +0000 (17:12 -0800)]
Fix more valgrind found test-before-set errors

7 years agoFix issue where everything was built '-O2 -g' while ignoring Dyninst user settings
Matthew LeGendre [Fri, 15 Feb 2013 01:12:18 +0000 (17:12 -0800)]
Fix issue where everything was built '-O2 -g' while ignoring Dyninst user settings

7 years agoFix two valgrind reported issues of test before set in PC
Matthew LeGendre [Fri, 15 Feb 2013 01:09:34 +0000 (17:09 -0800)]
Fix two valgrind reported issues of test before set in PC

7 years agoFix problem on BGQ/thread_db where we'd lose thread destroy events
Matthew LeGendre [Fri, 15 Feb 2013 01:08:42 +0000 (17:08 -0800)]
Fix problem on BGQ/thread_db where we'd lose thread destroy events

7 years agoChange Windows install dir from DYN/../include to DYN/include
Zuyu Zhang [Thu, 14 Feb 2013 00:02:49 +0000 (18:02 -0600)]
Change Windows install dir from DYN/../include to DYN/include

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Zuyu Zhang [Wed, 13 Feb 2013 17:10:01 +0000 (11:10 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoFixes after testing RemoteIO
Matthew LeGendre [Tue, 12 Feb 2013 19:03:31 +0000 (11:03 -0800)]
Fixes after testing RemoteIO

7 years agoFix build failure due to typo.
Andrew Bernat [Sat, 9 Feb 2013 15:12:28 +0000 (09:12 -0600)]
Fix build failure due to typo.

7 years agoMerge branch 'master' into bgq_ramdisk_io
Matthew LeGendre [Sat, 9 Feb 2013 00:38:45 +0000 (16:38 -0800)]
Merge branch 'master' into bgq_ramdisk_io

Conflicts:
proccontrol/src/bluegeneq.h
proccontrol/src/int_thread_db.h
stackwalk/make.module.tmpl

7 years agoIn progress work on BGQ RemoteIO access
Matthew LeGendre [Sat, 9 Feb 2013 00:32:25 +0000 (16:32 -0800)]
In progress work on BGQ RemoteIO access

7 years agoChange install directory for Windows from ../i386-unknown-nt4.0/lib to ../lib to...
Andrew Bernat [Fri, 8 Feb 2013 21:53:17 +0000 (15:53 -0600)]
Change install directory for Windows from ../i386-unknown-nt4.0/lib to ../lib to match Unix platforms

7 years agoMerge branch 'master' of cumin.cs.wisc.edu:/p/paradyn/development/bernat/builds/dyninst
Paradyn Project [Fri, 8 Feb 2013 16:37:30 +0000 (08:37 -0800)]
Merge branch 'master' of cumin.cs.wisc.edu:/p/paradyn/development/bernat/builds/dyninst

7 years agoAdd 32-bit support to the pc_addlibrary test; silence annoying warning on RHEL 5...
Andrew Bernat [Fri, 8 Feb 2013 21:36:28 +0000 (15:36 -0600)]
Add 32-bit support to the pc_addlibrary test; silence annoying warning on RHEL 5 systems.

7 years agoSkip undefined symbols during SymLite lookup
Paradyn Project [Fri, 8 Feb 2013 16:37:10 +0000 (08:37 -0800)]
Skip undefined symbols during SymLite lookup

7 years agoAdd some debugging to Proccontrol's loadLibrary code
Paradyn Project [Fri, 8 Feb 2013 16:37:00 +0000 (08:37 -0800)]
Add some debugging to Proccontrol's loadLibrary code

7 years agoCorrectly decode 64-bit op_v operands
Paradyn Project [Fri, 8 Feb 2013 16:36:40 +0000 (08:36 -0800)]
Correctly decode 64-bit op_v operands

7 years agoAdded code comments to int_process.h
Matthew LeGendre [Thu, 7 Feb 2013 00:39:28 +0000 (16:39 -0800)]
Added code comments to int_process.h

7 years agoNew BGQ OS version (V1R2) does not allow query for thread list before process' first...
Matthew LeGendre [Wed, 6 Feb 2013 22:43:55 +0000 (14:43 -0800)]
New BGQ OS version (V1R2) does not allow query for thread list before process' first instruction executes.  Work around in PC

7 years agoImprovements to debugging prints in PC
Matthew LeGendre [Wed, 6 Feb 2013 22:16:18 +0000 (14:16 -0800)]
Improvements to debugging prints in PC

7 years agoFix for PC's thread_db on BGQ. BGQ has several things like PIDs, we used the wrong...
Matthew LeGendre [Wed, 6 Feb 2013 22:13:45 +0000 (14:13 -0800)]
Fix for PC's thread_db on BGQ. BGQ has several things like PIDs, we used the wrong one.

7 years agoOur new while snippet was broken due to a backwards branch offset; fixed. Also, the...
Andrew Bernat [Wed, 6 Feb 2013 20:48:43 +0000 (14:48 -0600)]
Our new while snippet was broken due to a backwards branch offset; fixed. Also, the low-level x86 branch generator was assuming the caller would compensate for the instruction size; also fixed.

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Wed, 6 Feb 2013 18:03:50 +0000 (12:03 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoFix error in parsing when we reached an indirect tail call preceded by an add %rsp.
Andrew Bernat [Wed, 6 Feb 2013 18:03:40 +0000 (12:03 -0600)]
Fix error in parsing when we reached an indirect tail call preceded by an add %rsp.

7 years agoRemove broken debugging statements
Andrew Bernat [Tue, 5 Feb 2013 21:30:35 +0000 (15:30 -0600)]
Remove broken debugging statements

7 years agoAdd support for EFLAGS register access (read-only) on amd-64.
Andrew Bernat [Tue, 5 Feb 2013 21:25:55 +0000 (15:25 -0600)]
Add support for EFLAGS register access (read-only) on amd-64.

7 years agoFixed unguarded debug output in ParseAPI
Mike Lam [Tue, 5 Feb 2013 20:36:19 +0000 (15:36 -0500)]
Fixed unguarded debug output in ParseAPI

7 years agoRemoved unnecessary PatchAPI consistency check
Mike Lam [Tue, 5 Feb 2013 20:36:06 +0000 (15:36 -0500)]
Removed unnecessary PatchAPI consistency check

7 years agoRegister AST nodes should be untyped
Mike Lam [Tue, 5 Feb 2013 20:35:52 +0000 (15:35 -0500)]
Register AST nodes should be untyped

7 years agoAdded extra file types to .gitignore
Mike Lam [Tue, 5 Feb 2013 20:35:41 +0000 (15:35 -0500)]
Added extra file types to .gitignore

7 years agoFreeBSD fixes
Andrew Bernat [Tue, 5 Feb 2013 14:03:14 +0000 (08:03 -0600)]
FreeBSD fixes

7 years agoAdd SSE3/4.1/4.2 support as implemented by Mouhamed Gueye at Bull.
Andrew Bernat [Mon, 4 Feb 2013 22:31:31 +0000 (16:31 -0600)]
Add SSE3/4.1/4.2 support as implemented by Mouhamed Gueye at Bull.

7 years agoSkip the "red zone" when emitting loadLibrary code so we don't corrupt the stack...
Andrew Bernat [Mon, 4 Feb 2013 22:30:41 +0000 (16:30 -0600)]
Skip the "red zone" when emitting loadLibrary code so we don't corrupt the stack accidentally.

7 years agoPPC64 fixes for library injection.
Andrew R. Bernat [Mon, 4 Feb 2013 22:05:49 +0000 (14:05 -0800)]
PPC64 fixes for library injection.

7 years agoBuild fixes on ppc64
Matthew LeGendre [Sat, 2 Feb 2013 00:00:56 +0000 (16:00 -0800)]
Build fixes on ppc64

7 years agoAdd support for querying TOC from Symtab/Symlite via the SymReader interface
Andrew Bernat [Fri, 1 Feb 2013 22:24:59 +0000 (16:24 -0600)]
Add support for querying TOC from Symtab/Symlite via the SymReader interface

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Fri, 1 Feb 2013 21:44:39 +0000 (15:44 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoFix our tailcall parsing; we've observed conditional tailcalls in the wild and weren...
Andrew Bernat [Fri, 1 Feb 2013 21:44:28 +0000 (15:44 -0600)]
Fix our tailcall parsing; we've observed conditional tailcalls in the wild and weren't handling them. Also, mark functions uninstrumentable if we encounter unparsed instructions.

7 years agoFixes for memory permission changes using ProcControlAPI
Zuyu Zhang [Fri, 1 Feb 2013 20:41:13 +0000 (14:41 -0600)]
Fixes for memory permission changes using ProcControlAPI

7 years agoBetter error handling in PC injector and build fix on ppc64_bgq_ion
Matthew LeGendre [Fri, 1 Feb 2013 18:31:34 +0000 (10:31 -0800)]
Better error handling in PC injector and build fix on ppc64_bgq_ion

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Matthew LeGendre [Fri, 1 Feb 2013 17:50:45 +0000 (09:50 -0800)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoRemove InjectorAPI directory
Andrew Bernat [Fri, 1 Feb 2013 17:49:03 +0000 (11:49 -0600)]
Remove InjectorAPI directory

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Andrew Bernat [Fri, 1 Feb 2013 02:26:37 +0000 (20:26 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoMake sure to create modules when requested in BPatch_object.
Andrew Bernat [Fri, 1 Feb 2013 02:23:55 +0000 (20:23 -0600)]
Make sure to create modules when requested in BPatch_object.

7 years agoFix iRPC mechanism in PC's library injector
Matthew LeGendre [Fri, 1 Feb 2013 01:44:58 +0000 (17:44 -0800)]
Fix iRPC mechanism in PC's library injector

7 years agoNew pc_addlibrary test for testing library injection
Matthew LeGendre [Fri, 1 Feb 2013 01:43:18 +0000 (17:43 -0800)]
New pc_addlibrary test for testing library injection

7 years agoFixed PC problem where we could deliver empty library callbacks.
Matthew LeGendre [Fri, 1 Feb 2013 01:42:08 +0000 (17:42 -0800)]
Fixed PC problem where we could deliver empty library callbacks.

7 years agoAdded convience functions for PC low-level infMalloc and infFree
Matthew LeGendre [Fri, 1 Feb 2013 00:43:57 +0000 (16:43 -0800)]
Added convience functions for PC low-level infMalloc and infFree

7 years agoMoved breakpoint to not use InternalThreadState objects. Was interfering with injecto...
Matthew LeGendre [Fri, 1 Feb 2013 00:43:12 +0000 (16:43 -0800)]
Moved breakpoint to not use InternalThreadState objects. Was interfering with injector IRPCs

7 years agoFedora 18 glibc test
Andrew Bernat [Thu, 31 Jan 2013 23:15:15 +0000 (17:15 -0600)]
Fedora 18 glibc test

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Matthew LeGendre [Thu, 31 Jan 2013 20:36:38 +0000 (12:36 -0800)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoMove m4 files to autodyninst directory
Matthew LeGendre [Thu, 31 Jan 2013 20:35:41 +0000 (12:35 -0800)]
Move m4 files to autodyninst directory

7 years agoCleanup boost autoconf checks. Wrap system tap support in autoconf boost check
Matthew LeGendre [Thu, 31 Jan 2013 20:30:52 +0000 (12:30 -0800)]
Cleanup boost autoconf checks.  Wrap system tap support in autoconf boost check

7 years agoAdd BPatch_whileExpr
Andrew Bernat [Thu, 31 Jan 2013 19:58:46 +0000 (13:58 -0600)]
Add BPatch_whileExpr

7 years agoWork around problem where libstdc++ names its text sections .text.<foo>
Andrew Bernat [Thu, 31 Jan 2013 18:08:34 +0000 (12:08 -0600)]
Work around problem where libstdc++ names its text sections .text.<foo>

7 years agoRevert "Revert "Initial support for parsing SystemTap information from ELF binaries.""
Matthew LeGendre [Thu, 31 Jan 2013 19:08:16 +0000 (11:08 -0800)]
Revert "Revert "Initial support for parsing SystemTap information from ELF binaries.""

This reverts commit 087ed6f402dff99078742bc8da0834acf26cd41c.

7 years agoFurther work on RemoteIO
Matthew LeGendre [Thu, 31 Jan 2013 17:51:59 +0000 (09:51 -0800)]
Further work on RemoteIO

7 years agoMerge branch 'master' of git.dyninst.org:/pub/dyninst
Zuyu Zhang [Thu, 31 Jan 2013 00:34:26 +0000 (18:34 -0600)]
Merge branch 'master' of git.dyninst.org:/pub/dyninst

7 years agoAdd Kevin's uncommited comments and fix inconsistent output for function name
Zuyu Zhang [Thu, 31 Jan 2013 00:27:08 +0000 (18:27 -0600)]
Add Kevin's uncommited comments and fix inconsistent output for function name