Cleanup warnings
authorPeter Foley <pefoley2@pefoley.com>
Thu, 28 Apr 2016 00:30:48 +0000 (20:30 -0400)
committerPeter Foley <pefoley2@pefoley.com>
Fri, 6 May 2016 15:27:33 +0000 (11:27 -0400)
commit8840c6d2b58f65f8286b9178be6cd3a5e8614d7f
tree714e3785b5239374f9bdd5602f952cd6de9648c4
parentc1bf1c730c46319e11e1c3d6684c4b92005ae52a
Cleanup warnings

Fix a bunch of misc warnings.

[  8%] Building CXX object common/CMakeFiles/common.dir/src/arch-aarch64.C.o
/home/peter/dyninst/common/src/arch-aarch64.C:111:45: warning: unused parameter ‘ptr’ [-Wunused-parameter]
 void instruction::setInstruction(codeBuf_t *ptr, Address) {
                                             ^
/home/peter/dyninst/common/src/arch-aarch64.C:143:40: warning: unused parameter ‘from’ [-Wunused-parameter]
 unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {
                                        ^
/home/peter/dyninst/common/src/arch-aarch64.C:143:54: warning: unused parameter ‘to’ [-Wunused-parameter]
 unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {
                                                      ^
/home/peter/dyninst/common/src/arch-aarch64.C:143:67: warning: unused parameter ‘addr_width’ [-Wunused-parameter]
 unsigned instruction::jumpSize(Address from, Address to, unsigned addr_width) {
                                                                   ^
/home/peter/dyninst/common/src/arch-aarch64.C:149:40: warning: unused parameter ‘disp’ [-Wunused-parameter]
 unsigned instruction::jumpSize(Address disp, unsigned addr_width) {
                                        ^
/home/peter/dyninst/common/src/arch-aarch64.C:149:55: warning: unused parameter ‘addr_width’ [-Wunused-parameter]
 unsigned instruction::jumpSize(Address disp, unsigned addr_width) {
                                                       ^
In file included from /home/peter/dyninst/common/h/dyn_regs.h:38:0,
                 from /home/peter/dyninst/common/h/dyntypes.h:170,
                 from /home/peter/dyninst/common/src/Types.h:168,
                 from /home/peter/dyninst/common/src/arch-aarch64.C:31:
/home/peter/dyninst/common/src/arch-aarch64.C: In member function ‘unsigned int NS_aarch64::instruction::getBranchTargetReg() const’:
/home/peter/dyninst/common/src/arch-aarch64.C:204:24: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
         assert( regNum >= 0 || regNum <= 30);
                        ^
[ 14%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/Function.C.o
/home/peter/dyninst/symtabAPI/src/Function.C:54:36: warning: unused parameter ‘sym’ [-Wunused-parameter]
 FunctionBase::FunctionBase(Symbol *sym) :
                                    ^
/home/peter/dyninst/symtabAPI/src/Function.C:76:36: warning: unused parameter ‘m’ [-Wunused-parameter]
 FunctionBase::FunctionBase(Module *m) :
                                    ^
/home/peter/dyninst/symtabAPI/src/Function.C:475:61: warning: unused parameter ‘isPrimary’ [-Wunused-parameter]
 bool InlinedFunction::addMangledName(std::string name, bool isPrimary)
                                                             ^
/home/peter/dyninst/symtabAPI/src/Function.C:481:60: warning: unused parameter ‘isPrimary’ [-Wunused-parameter]
 bool InlinedFunction::addPrettyName(std::string name, bool isPrimary)
                                                            ^
[ 22%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/dwarfWalker.C.o
In file included from /home/peter/dyninst/symtabAPI/src/dwarfWalker.C:31:0:
/home/peter/dyninst/symtabAPI/src/dwarfWalker.h: In constructor ‘Dyninst::SymtabAPI::DwarfWalker::DwarfWalker(Dyninst::SymtabAPI::Symtab*, Dwarf_Debug_s*&)’:
/home/peter/dyninst/symtabAPI/src/dwarfWalker.h:314:14: warning: ‘Dyninst::SymtabAPI::DwarfWalker::compile_offset’ will be initialized after [-Wreorder]
    Dwarf_Off compile_offset;
              ^
/home/peter/dyninst/symtabAPI/src/dwarfWalker.h:292:12: warning:   ‘char** Dyninst::SymtabAPI::DwarfWalker::srcFileList_’ [-Wreorder]
     char** srcFileList_;
            ^
/home/peter/dyninst/symtabAPI/src/dwarfWalker.C:76:1: warning:   when initialized here [-Wreorder]
 DwarfWalker::DwarfWalker(Symtab *symtab, Dwarf_Debug &dbg)
 ^
[ 22%] Building CXX object symtabAPI/CMakeFiles/symtabAPI.dir/src/emitElf-64.C.o
/home/peter/dyninst/symtabAPI/src/emitElf-64.C: In member function ‘bool Dyninst::SymtabAPI::emitElf64<ElfTypes>::driver(std::string) [with ElfTypes = Dyninst::SymtabAPI::ElfTypes32; std::string = std::basic_string<char>]’:
/home/peter/dyninst/symtabAPI/src/emitElf-64.C:868:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
         write(newfd, &offset, sizeof(Elf_Off));
         ^
/home/peter/dyninst/symtabAPI/src/emitElf-64.C: In member function ‘bool Dyninst::SymtabAPI::emitElf64<ElfTypes>::driver(std::string) [with ElfTypes = Dyninst::SymtabAPI::ElfTypes64; std::string = std::basic_string<char>]’:
/home/peter/dyninst/symtabAPI/src/emitElf-64.C:868:9: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
[ 26%] Building CXX object instructionAPI/CMakeFiles/instructionAPI.dir/src/InstructionDecoder-x86.C.o
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-x86.C: In member function ‘bool Dyninst::InstructionAPI::InstructionDecoder_x86::decodeOneOperand(const Dyninst::InstructionAPI::InstructionDecoder::buffer&, const NS_x86::ia32_operand&, int&, const Dyninst::InstructionAPI::Instruction*, bool, bool)’:
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-x86.C:795:12: warning: variable ‘has_vex’ set but not used [-Wunused-but-set-variable]
       bool has_vex = 0;
            ^
[ 27%] Building CXX object instructionAPI/CMakeFiles/instructionAPI.dir/src/InstructionDecoder-aarch64.C.o
In file included from /home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:31:0:
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h: In constructor ‘Dyninst::InstructionAPI::InstructionDecoder_aarch64::InstructionDecoder_aarch64(Dyninst::Architecture)’:
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h:387:30: warning: ‘Dyninst::InstructionAPI::InstructionDecoder_aarch64::_Q’ will be initialized after [-Wreorder]
                 unsigned int _Q;
                              ^
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.h:239:31: warning:   ‘int Dyninst::InstructionAPI::InstructionDecoder_aarch64::size’ [-Wreorder]
                 int _szField, size;
                               ^
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:141:5: warning:   when initialized here [-Wreorder]
     InstructionDecoder_aarch64::InstructionDecoder_aarch64(Architecture a)
     ^
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C: In member function ‘Dyninst::InstructionAPI::Expression::Ptr Dyninst::InstructionAPI::InstructionDecoder_aarch64::makeMemRefIndexLiteral()’:
/home/peter/dyninst/instructionAPI/src/InstructionDecoder-aarch64.C:1086:85: warning: ‘rt’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     return makeDereferenceExpression(makeAddExpression(makePCExpr(), label, u64), rt);
                                                                                     ^
[ 27%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/Parser.C.o
/home/peter/dyninst/parseAPI/src/Parser.C: In member function ‘void Dyninst::ParseAPI::Parser::parse_frame(Dyninst::ParseAPI::ParseFrame&, bool)’:
/home/peter/dyninst/parseAPI/src/Parser.C:888:20: warning: variable ‘ce’ set but not used [-Wunused-but-set-variable]
             Edge * ce = NULL;
                    ^
[ 32%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/IA_aarch64Details.C.o
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:111:59: warning: unused parameter ‘blockToCheck’ [-Wunused-parameter]
 bool IA_aarch64Details::findTableAddrNoTOC(const IA_IAPI* blockToCheck)
                                                           ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:33: warning: unused parameter ‘e’ [-Wunused-parameter]
   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)
                                 ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:54: warning: unused parameter ‘visited’ [-Wunused-parameter]
   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)
                                                      ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:136:83: warning: unused parameter ‘worklist’ [-Wunused-parameter]
   void processPredecessor(Edge* e, std::set<Block*>& visited, std::deque<Block*>& worklist)
                                                                                   ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:142:81: warning: unused parameter ‘start’ [-Wunused-parameter]
 bool IA_aarch64Details::scanForAdjustOrBase(IA_IAPI::allInsns_t::const_iterator start,
                                                                                 ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:143:44: warning: unused parameter ‘end’ [-Wunused-parameter]
        IA_IAPI::allInsns_t::const_iterator end,
                                            ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:144:26: warning: unused parameter ‘jumpAddrReg’ [-Wunused-parameter]
        RegisterAST::Ptr &jumpAddrReg) {
                          ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:150:75: warning: unused parameter ‘start’ [-Wunused-parameter]
 bool IA_aarch64Details::findTableBase(IA_IAPI::allInsns_t::const_iterator start,
                                                                           ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:151:45: warning: unused parameter ‘end’ [-Wunused-parameter]
         IA_IAPI::allInsns_t::const_iterator end) {
                                             ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:159:47: warning: unused parameter ‘currBlk’ [-Wunused-parameter]
 bool IA_aarch64Details::parseJumpTable(Block* currBlk,
                                               ^
/home/peter/dyninst/parseAPI/src/IA_aarch64Details.C:160:59: warning: unused parameter ‘outEdges’ [-Wunused-parameter]
          std::vector<std::pair< Address, EdgeTypeEnum> >& outEdges)
                                                           ^
[ 33%] Building CXX object parseAPI/CMakeFiles/parseAPI.dir/src/BoundFactData.C.o
/home/peter/dyninst/parseAPI/src/BoundFactData.C:604:39: warning: unused parameter ‘b’ [-Wunused-parameter]
 static bool IsInReadOnlyRegion(Block *b, Address low, Address high) {
                                       ^
[ 54%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/loadLibrary/codegen-aarch64.C.o
/home/peter/dyninst/proccontrol/src/loadLibrary/codegen-aarch64.C: In member function ‘bool Dyninst::ProcControlAPI::Codegen::generateCallAARCH64(Dyninst::Address, const std::vector<long unsigned int>&)’:
/home/peter/dyninst/proccontrol/src/loadLibrary/codegen-aarch64.C:53:10: warning: unused variable ‘blr_buf’ [-Wunused-variable]
     char blr_buf[] = {
          ^
[ 56%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/mmapalloc.C.o
/home/peter/dyninst/proccontrol/src/mmapalloc.C: In member function ‘virtual bool mmap_alloc_process::plat_createAllocationSnippet(Dyninst::Address, bool, long unsigned int, void*&, long unsigned int&, long unsigned int&)’:
/home/peter/dyninst/proccontrol/src/mmapalloc.C:597:22: warning: variable ‘addr_size’ set but not used [-Wunused-but-set-variable]
         unsigned int addr_size;
                      ^
[ 56%] Building CXX object proccontrol/CMakeFiles/pcontrol.dir/src/linux.C.o
In file included from /home/peter/dyninst/proccontrol/src/linux.C:48:0:
/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘virtual bool DecoderLinux::decode(Dyninst::ProcControlAPI::ArchEvent*, std::vector<boost::shared_ptr<Dyninst::ProcControlAPI::Event> >&)’:
/home/peter/dyninst/proccontrol/h/PCErrors.h:100:108: warning: format ‘%p’ expects argument of type ‘void*’, but argument 6 has type ‘Dyninst::MachRegisterVal {aka long unsigned int}’ [-Wformat=]
          fprintf(pctrl_err_out, "[%s:%u-%s] - Error: " format, FILE__, __LINE__, thrdName(), ## __VA_ARGS__); \
                                                                                                            ^
/home/peter/dyninst/proccontrol/src/linux.C:341:25: note: in expansion of macro ‘perr_printf’
                         perr_printf("ARM-error: Failed to remove inserted BP, addr %p.\n",
                         ^
/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘virtual bool linux_process::plat_attachWillTriggerStop()’:
/home/peter/dyninst/proccontrol/src/linux.C:1144:42: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’, declared with attribute warn_unused_result [-Wunused-result]
             &tmpPid, &tmpPid, &ttyNumber);
                                          ^
/home/peter/dyninst/proccontrol/src/linux.C: In member function ‘bool linux_process::readStatM(long unsigned int&, long unsigned int&, long unsigned int&)’:
/home/peter/dyninst/proccontrol/src/linux.C:1927:35: warning: ignoring return value of ‘int fscanf(FILE*, const char*, ...)’, declared with attribute warn_unused_result [-Wunused-result]
           &text, &lib, &data, &dt);
                                   ^
[ 77%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/function.C.o
/home/peter/dyninst/dyninstAPI/src/function.C: In member function ‘bool func_instance::createOffsetVector_Symbols()’:
/home/peter/dyninst/dyninstAPI/src/function.C:1205:18: warning: variable ‘bp’ set but not used [-Wunused-but-set-variable]
     MachRegister bp = MachRegister::getFramePointer(arch);
                  ^
/home/peter/dyninst/dyninstAPI/src/function.C: In member function ‘void func_instance::createTMap_internal(StackMod*, StackLocation*, TMap*)’:
/home/peter/dyninst/dyninstAPI/src/function.C:1530:27: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
     StackAnalysis::Height size = loc->size();
                           ^
[ 95%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/codegen-x86.C.o
/home/peter/dyninst/dyninstAPI/src/codegen-x86.C: In static member function ‘static bool insnCodeGen::modifyDisp(long int, NS_x86::instruction&, codeGen&, Dyninst::Architecture, Dyninst::Address)’:
/home/peter/dyninst/dyninstAPI/src/codegen-x86.C:1394:13: warning: variable ‘sib_scale_factor’ set but not used [-Wunused-but-set-variable]
         int sib_scale_factor;
             ^
[ 96%] Building CXX object dyninstAPI/CMakeFiles/dyninstAPI.dir/src/linux.C.o
/home/peter/dyninst/dyninstAPI/src/linux.C: In static member function ‘static bool BinaryEdit::getResolvedLibraryPath(const string&, std::vector<std::basic_string<char> >&)’:
/home/peter/dyninst/dyninstAPI/src/linux.C:223:37: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
         fgets(buffer, 512, ldconfig); // ignore first line
                                     ^
18 files changed:
common/src/arch-aarch64.C
dyninstAPI/src/codegen-x86.C
dyninstAPI/src/function.C
dyninstAPI/src/linux.C
instructionAPI/CMakeLists.txt
instructionAPI/h/Result.h
instructionAPI/src/InstructionDecoder-aarch64.C
instructionAPI/src/InstructionDecoder-x86.C
parseAPI/src/BoundFactData.C
parseAPI/src/IA_aarch64Details.C
parseAPI/src/Parser.C
proccontrol/src/DecoderWindows.C
proccontrol/src/linux.C
proccontrol/src/loadLibrary/codegen-aarch64.C
proccontrol/src/mmapalloc.C
symtabAPI/src/Function.C
symtabAPI/src/dwarfWalker.C
symtabAPI/src/emitElf-64.C