patchAPI: Remove 'during' before destroying it
authorJosh Stone <jistone@redhat.com>
Thu, 21 Nov 2013 01:01:55 +0000 (17:01 -0800)
committerJosh Stone <jistone@redhat.com>
Sat, 14 Dec 2013 02:07:47 +0000 (18:07 -0800)
commit23b7647932591d398e6c15a7b421b8f4b75129c6
treefb0196971d4f8040ea2401a07efc86a791c0298e
parente6b2e041bbd62406ab02a8ccef84aff21ba75f3c
patchAPI: Remove 'during' before destroying it

In PatchParseCallback::remove_edge_cb, if it has pe->points_.during,
then this is both destroyed and removed from PatchFunctions.  However,
PatchCallback::destroy will delete the point if not batching, and
PatchFunction::remove dereferences it, so destroy must come after.

Reported by Coverity as USE_AFTER_FREE.
patchAPI/src/ParseCallback.C